Skip to content

Add more test for adding batch to live chat model eval projects #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Jun 27, 2024

Description

I have updated a test and added a new test to show that adding new batch to a live model chat evaluation project does not fail as expected

FYI the reason my initial test passed, i.e. project.create_batch() threw an exception, was because I used incorrect data row type for my test. So exception was for that reason, not because api explicitly disallowed created new batches for live model evaluation projects as it should.

FYI Project create_batch() uses two apis, depending whether we are adding less than or more than 1K rows:

  • createEmptyBatch / addDataRowsToBatchAsync for async
  • createBatchV2 for sync

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner June 27, 2024 20:53
@vbrodsky vbrodsky force-pushed the VB/add-more-mmc-batch-tests branch from 04195e1 to 51cc37c Compare June 27, 2024 20:56
@vbrodsky vbrodsky merged commit 23cdbee into develop Jun 28, 2024
15 of 20 checks passed
@vbrodsky vbrodsky deleted the VB/add-more-mmc-batch-tests branch June 28, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants